test(NODE-6318): utf runner withTransaction callback propagates errors from operations #4193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
force-pushed
the
fix-unified-withTxn
branch
2 times, most recently
from
c1e995e
to
44b425a
Compare
…s from operations
nbbeeken
force-pushed
the
fix-unified-withTxn
branch
from
44b425a
to
e2ac2fa
Compare
W-A-James
added
the
Primary Review
W-A-James
previously requested changes
Aug 9, 2024
test/integration/unified-test-format/unified_test_format.test.ts
Outdated
Show resolved
Hide resolved
|
Bookkeeping, I'm taking over Warren's review while he's OOO. |
aditi-khare-mongoDB
requested changes
Aug 12, 2024
aditi-khare-mongoDB
approved these changes
Aug 12, 2024
aditi-khare-mongoDB
dismissed
W-A-James’s stale review
Warren is OOO and I'm picking up primary on this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Is there new documentation needed for these changes?
No
What is the motivation for this change?
It is needed to test withTransaction correctly.
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript