Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(NODE-6325): implement document sequence support #4201

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Conversation

durran
Copy link
Member

@durran durran commented Aug 18, 2024

Description

Implements OP_MSG type 1 sections for document sequences.

What is changing?

  • Adds a DocumentSequence object that can be added to commands internally to leverage type 1 sections.
  • Updates OpMsgRequest to properly handle document sequences in commands.
  • Adds unit tests on OpMsgRequest#toBin
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-6325

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran marked this pull request as ready for review August 19, 2024 18:37
@nbbeeken nbbeeken self-assigned this Aug 19, 2024
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 19, 2024
@nbbeeken nbbeeken self-requested a review August 19, 2024 18:46
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some quick win improvements.

We're calling this a feat but there's no public facing changes, maybe a refactor would be more accurate?

src/cmap/commands.ts Outdated Show resolved Hide resolved
src/cmap/commands.ts Outdated Show resolved Hide resolved
src/cmap/commands.ts Show resolved Hide resolved
src/cmap/commands.ts Outdated Show resolved Hide resolved
src/cmap/commands.ts Outdated Show resolved Hide resolved
@durran durran changed the title feat(NODE-6325): implement document sequence support refactor(NODE-6325): implement document sequence support Aug 20, 2024
@durran durran requested a review from nbbeeken August 20, 2024 14:55
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbbeeken nbbeeken merged commit 55bdeaa into main Aug 20, 2024
26 of 30 checks passed
@nbbeeken nbbeeken deleted the NODE-6325 branch August 20, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants