New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-6327): new client bulk write types and builders #4205

Merged

baileympearson merged 7 commits into main from NODE-6327

Aug 28, 2024

Member

durran commented Aug 21, 2024 •

edited

Loading

Description

Creates the new client bulk write model types and options as well as the builders for the bulk write command.

What is changing?

Creates the new client bulk write model types.
Creates a client bulk write command builder that delegates to the various model builders to build the operations.
Ensures the ops field of the bulk write command is a document sequence
Ensures the nsInfo field of the bulk write command is a unique document sequence.
Adds a bunch-o-unit-tests

Is there new documentation needed for these changes?

None. docs changes will come on the last ticket of the epic as well as the release highlights.

What is the motivation for this change?

Double check the following

Ran npm run check:lint script
Self-review completed using the steps outlined here
PR title follows the correct format: type(NODE-xxxx)[!]: description
- Example: feat(NODE-1234)!: rewriting everything in coffeescript
Changes are covered by tests
New TODOs have a related JIRA ticket

durran changed the title ~~feat(NODE-6327): implement client bulk write types and builders~~ feat(NODE-6327): new client bulk write types and builders

durran force-pushed the NODE-6327 branch 8 times, most recently from 1cb2bf1 to fff99b9 Compare

August 21, 2024 22:09

durran commented

View reviewed changes

src/operations/client_bulk_write/command_builder.ts Show resolved Hide resolved

durran marked this pull request as ready for review

August 21, 2024 22:26

nbbeeken self-assigned this

nbbeeken self-requested a review

August 22, 2024 18:11

nbbeeken added the Primary Review label

nbbeeken assigned baileympearson and unassigned nbbeeken

baileympearson reviewed

View reviewed changes

src/operations/client_bulk_write/command_builder.ts Outdated Show resolved Hide resolved

baileympearson requested changes

View reviewed changes

Contributor

baileympearson left a comment

Looks good! The testing made the PR straightforward to review.

src/operations/client_bulk_write/command_builder.ts Outdated Show resolved Hide resolved

src/operations/client_bulk_write/command_builder.ts Show resolved Hide resolved

src/operations/client_bulk_write/common.ts Outdated Show resolved Hide resolved

src/operations/client_bulk_write/command_builder.ts Outdated Show resolved Hide resolved

src/operations/client_bulk_write/command_builder.ts Outdated Show resolved Hide resolved

src/operations/client_bulk_write/command_builder.ts Show resolved Hide resolved

src/operations/client_bulk_write/command_builder.ts Show resolved Hide resolved

src/operations/client_bulk_write/command_builder.ts Outdated Show resolved Hide resolved

src/operations/client_bulk_write/command_builder.ts Outdated Show resolved Hide resolved

durran requested a review from baileympearson

August 27, 2024 18:07

baileympearson previously approved these changes

View reviewed changes

Contributor

baileympearson left a comment

One small docs change and waiting for CI. Otherwise looks good.

src/operations/client_bulk_write/common.ts Outdated Show resolved Hide resolved

durran dismissed baileympearson’s stale review via

04473da

August 27, 2024 18:27

baileympearson added Team Review and removed Primary Review labels

nbbeeken requested changes

View reviewed changes

src/operations/client_bulk_write/command_builder.ts Outdated Show resolved Hide resolved

src/operations/client_bulk_write/command_builder.ts Outdated Show resolved Hide resolved

src/operations/client_bulk_write/command_builder.ts Outdated Show resolved Hide resolved

src/operations/client_bulk_write/common.ts Outdated Show resolved Hide resolved

src/operations/client_bulk_write/command_builder.ts Outdated Show resolved Hide resolved

durran added 6 commits

August 27, 2024 22:46


feat(NODE-6327): implement client bulk write types and builders

7985beb


refactor: use functions not objects

b521d50


docs: update comments

a953109


docs: typo

94a9730


chore: more typing

7d50499


chore: update operation types

9272b7a

durran force-pushed the NODE-6327 branch from b240306 to 9272b7a Compare

August 27, 2024 20:46

durran requested a review from nbbeeken

August 27, 2024 20:47

nbbeeken requested changes

View reviewed changes

src/operations/client_bulk_write/command_builder.ts Outdated Show resolved Hide resolved

src/operations/client_bulk_write/common.ts Outdated Show resolved Hide resolved

durran requested review from nbbeeken and baileympearson

August 28, 2024 15:19


refactor: next batch comments

fd1d467

nbbeeken approved these changes

View reviewed changes

Contributor

nbbeeken left a comment

LGTM. Keep in mind this is going in as a feat but no release notes understandably because a later PR will include the actual API. So we'll just want to remember to omit this bullet from next release.

baileympearson approved these changes

View reviewed changes

Contributor

baileympearson commented Aug 28, 2024

CI failures are unrelated.

baileympearson merged commit 6d65ae7 into main

27 of 30 checks passed

baileympearson deleted the NODE-6327 branch

August 28, 2024 19:49

github-actions bot mentioned this pull request

chore(main): release 6.9.0 [skip-ci] #4164

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment