-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-6329): client bulk write happy path #4206
Conversation
bbc3701
to
77789ff
Compare
5c65c07
to
c74fcea
Compare
99506fa
to
f6b2bf2
Compare
b19b0f1
to
5f3d4f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two small comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a small lint failure, we need to add the cursor to the list of public APIs. Quick question about didUpsert too
Yes that's fixed in the PR now. |
Description
Implements the "happy path" for the new client bulk write in 8.0
What is changing?
MongoClient#bulkWrite
and all associated model and return types.Is there new documentation needed for these changes?
None. Note release note highlights will be added on last ticket.
What is the motivation for this change?
NODE-6329
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript