Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(NODE-6317): fix test assertions and naming #4217

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Sep 3, 2024

Description

What is changing?

Renaming test and reworking assertion removed in #4212

Is there new documentation needed for these changes?

No

What is the motivation for this change?

Testing correctness

Release Highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James marked this pull request as ready for review September 3, 2024 20:52
@nbbeeken nbbeeken self-assigned this Sep 3, 2024
@nbbeeken nbbeeken added the Team Review Needs review from team label Sep 3, 2024
Copy link
Contributor

@aditi-khare-mongoDB aditi-khare-mongoDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job adding the additional test too!

@nbbeeken nbbeeken merged commit 65e0e15 into main Sep 4, 2024
30 checks passed
@nbbeeken nbbeeken deleted the NODE-6317-assertion-fixes branch September 4, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants