fix(NODE-6362): cache cursor deserialization options across deserialize calls #4221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
force-pushed
the
fix-regress
branch
from
b3c6494
to
a5ddeb9
Compare
baileympearson
changed the title
baileympearson
force-pushed
the
fix-regress
branch
3 times, most recently
from
a598416
to
5e9bbc2
Compare
baileympearson
changed the title
baileympearson
force-pushed
the
fix-regress
branch
from
3880d93
to
fb8390f
Compare
nbbeeken
added
the
Primary Review
nbbeeken
requested changes
Sep 9, 2024
test/integration/node-specific/bson-options/utf8_validation.test.ts
Outdated
Show resolved
Hide resolved
nbbeeken
changed the title
nbbeeken
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Forward-port of #4220.
Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
Fixed
enableUtf8ValidationoptionStarting in v6.8.0 we inadvertently removed the ability to disable UTF-8 validation when deserializing BSON. Validation is normally a good thing, but it was always meant to be configurable and the recent Node.js runtime issues (v22.7.0) make this option indispensable for avoiding errors from mistakenly generated invalid UTF-8 bytes.
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript