Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-6367): enable mixed use of iteration APIs #4231

Merged
merged 15 commits into from
Sep 12, 2024
Merged

fix(NODE-6367): enable mixed use of iteration APIs #4231

merged 15 commits into from
Sep 12, 2024

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Sep 11, 2024 •
edited
Loading

Description

What is changing?

Is there new documentation needed for these changes?

No

What is the motivation for this change?

Fixing mixed use of cursor.next and for await (const doc of cursor).

Release Highlight

Restore mixed use of cursor.next() and cursor[Symbol.asyncIterator]

In 6.8.0, we inadvertently prevented the use of cursor.next() along with using for await syntax to iterate cursors. This use-case has now been restored.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James marked this pull request as ready for review September 11, 2024 02:07
@nbbeeken nbbeeken self-assigned this Sep 11, 2024
@nbbeeken nbbeeken self-requested a review September 11, 2024 14:49
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Sep 11, 2024
@nbbeeken nbbeeken merged commit 08912c8 into main Sep 12, 2024
28 of 30 checks passed
@nbbeeken nbbeeken deleted the NODE-6367 branch September 12, 2024 13:28
@github-actions github-actions bot mentioned this pull request Sep 12, 2024
Merged
W-A-James added a commit that referenced this pull request Sep 12, 2024
@W-A-James
fix(NODE-6367): enable mixed use of iteration APIs (#4231)
94d5d62
This was referenced Oct 3, 2024
Merged
Merged
Merged
Merged
Closed
@akanchhaS akanchhaS mentioned this pull request Oct 4, 2024
Open
@zntb zntb mentioned this pull request Oct 4, 2024
Closed
@MohammadGhajari MohammadGhajari mentioned this pull request Oct 4, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Oct 4, 2024
Open
@lryanle lryanle mentioned this pull request Oct 4, 2024
Open
@lydmoon lydmoon mentioned this pull request Oct 4, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Oct 4, 2024
Closed
@issam-seghir issam-seghir mentioned this pull request Oct 4, 2024
Open
@TartejBrothers TartejBrothers mentioned this pull request Oct 4, 2024
Merged
@visrut-at-incubyte visrut-at-incubyte mentioned this pull request Oct 4, 2024
Open
@IzzyDotExe IzzyDotExe mentioned this pull request Oct 4, 2024
Merged
This was referenced Oct 5, 2024
Merged
Merged
Merged
@arenault-pass arenault-pass mentioned this pull request Oct 5, 2024
Closed
@MoaidHashem3 MoaidHashem3 mentioned this pull request Oct 5, 2024
Open
@mkusztal mkusztal mentioned this pull request Oct 5, 2024
Open
@WontonSam WontonSam mentioned this pull request Oct 5, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Oct 6, 2024
Closed
@Abhishekh669 Abhishekh669 mentioned this pull request Oct 25, 2024
Open
@aliakseikrauchanka aliakseikrauchanka mentioned this pull request Oct 25, 2024
Open
@parseplatformorg parseplatformorg mentioned this pull request Oct 26, 2024
Closed
@Xcaciv Xcaciv mentioned this pull request Oct 26, 2024
Open
@MohammadGhajari MohammadGhajari mentioned this pull request Oct 28, 2024
Open
@lydmoon lydmoon mentioned this pull request Oct 28, 2024
Open
@xeni09 xeni09 mentioned this pull request Oct 28, 2024
Merged
@abaum65 abaum65 mentioned this pull request Oct 29, 2024
Open
@mentorscx mentorscx mentioned this pull request Nov 7, 2024
Open
@prosenjit07 prosenjit07 mentioned this pull request Nov 8, 2024
Open
@parseplatformorg parseplatformorg mentioned this pull request Nov 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@W-A-James @nbbeeken