Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(NODE-5788): rework change stream close rejection test #4232

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

  • The change stream tests removed were flaky, I recaptured what I think is the intended behavior, pending promises are rejected by a close call
  • Further clarity will be worked on in NODE-5221
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Reduce flaky tests.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant