fix(NODE-6377): remove noResponse option

src/cmap/connection.ts

@@ -81,7 +81,6 @@ export interface CommandOptions extends BSONSerializeOptions {
   /** Session to use for the operation */
   session?: ClientSession;
   documentsReturnedIn?: string;
-  noResponse?: boolean;
   omitReadPreference?: boolean;
 
   // TODO(NODE-2802): Currently the CommandOptions take a property willRetryWrite which is a hint
@@ -94,6 +93,9 @@ export interface CommandOptions extends BSONSerializeOptions {
   writeConcern?: WriteConcern;
 
   directConnection?: boolean;
+
+  /** Triggers fire-and-forget protocol for commands that don't support WriteConcern */
+  moreToCome?: boolean;
 }
 
 /** @public */
@@ -439,7 +441,7 @@ export class Connection extends TypedEventEmitter<ConnectionEvents> {
         zlibCompressionLevel: this.description.zlibCompressionLevel
       });
 
-      if (options.noResponse || message.moreToCome) {
+      if (message.moreToCome) {
         yield MongoDBResponse.empty;
         return;
       }
@@ -527,11 +529,7 @@ export class Connection extends TypedEventEmitter<ConnectionEvents> {
             new CommandSucceededEvent(
               this,
               message,
-              options.noResponse
-                ? undefined
-                : message.moreToCome
-                  ? { ok: 1 }
-                  : (object ??= document.toObject(bsonOptions)),
+              message.moreToCome ? { ok: 1 } : (object ??= document.toObject(bsonOptions)),
               started,
               this.description.serverConnectionId
             )

src/mongo_client.ts

@@ -647,7 +647,7 @@ export class MongoClient extends TypedEventEmitter<MongoClientEvents> implements
             this,
             new RunAdminCommandOperation(
               { endSessions },
-              { readPreference: ReadPreference.primaryPreferred, noResponse: true }
+              { readPreference: ReadPreference.primaryPreferred, moreToCome: true }
             )
           );
         } catch (error) {

src/operations/command.ts

@@ -55,7 +55,6 @@ export interface CommandOperationOptions
   // Admin command overrides.
   dbName?: string;
   authdb?: string;
-  noResponse?: boolean;
 }
 
 /** @internal */

src/operations/run_command.ts

@@ -51,7 +51,7 @@ export class RunAdminCommandOperation<T = Document> extends AbstractOperation<T>
   constructor(
     public command: Document,
     public override options: RunCommandOptions & {
-      noResponse?: boolean;
+      moreToCome?: boolean;
       bypassPinningCheck?: boolean;
     }
   ) {

test/integration/collection-management/collection.test.ts

@@ -1,6 +1,13 @@
 import { expect } from 'chai';
-
-import { Collection, type Db, type MongoClient, MongoServerError } from '../../mongodb';
+import * as sinon from 'sinon';
+
+import {
+  Collection,
+  CreateIndexesOperation,
+  type Db,
+  type MongoClient,
+  MongoServerError
+} from '../../mongodb';
 import { type FailPoint } from '../../tools/utils';
 import { setupDatabase } from '../shared';
 
@@ -422,6 +429,41 @@ describe('Collection', function () {
     });
   });
 
+  describe('#createIndex', () => {
+    let client: MongoClient;
+    let db: Db;
+    let coll: Collection<{ a: string }>;
+    const ERROR_RESPONSE = {
+      ok: 0,
+      errmsg:
+        'WiredTigerIndex::insert: key too large to index, failing  1470 { : "56f37cb8e4b089e98d52ab0e", : "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa..." }',
+      code: 17280
+    };
+
+    beforeEach(async function () {
+      client = configuration.newClient({ w: 1 });
+      db = client.db(configuration.db);
+      coll = db.collection('test_coll');
+      await client.connect();
+      sinon.stub(CreateIndexesOperation.prototype, 'execute').callsFake(() => {
+        throw ERROR_RESPONSE;
+      });
+    });
+
+    afterEach(async function () {
+      await coll.drop();
+      await client.close();
+      sinon.restore();
+    });
+
+    it('should error when createIndex fails', async function () {
+      const e = await coll.createIndex({ a: 1 }).catch(e => e);
+      expect(e).to.have.property('ok', ERROR_RESPONSE.ok);
+      expect(e).to.have.property('errmsg', ERROR_RESPONSE.errmsg);
+      expect(e).to.have.property('code', ERROR_RESPONSE.code);
+    });
+  });
+
   describe('countDocuments()', function () {
     let client: MongoClient;
     let collection: Collection<{ test: string }>;

test/integration/connection-monitoring-and-pooling/connection.test.ts

@@ -144,6 +144,21 @@ describe('Connection', function () {
         }
       }
     });
+
+    it('supports fire-and-forget messages', async function () {
+      const options: ConnectionOptions = {
+        ...commonConnectOptions,
+        connectionType: Connection,
+        ...this.configuration.options,
+        metadata: makeClientMetadata({ driverInfo: {} }),
+        extendedMetadata: addContainerMetadata(makeClientMetadata({ driverInfo: {} }))
+      };
+
+      const conn = await connect(options);
+      const readSpy = sinon.spy(conn, 'readMany');
+      await conn.command(ns('$admin.cmd'), { ping: 1 }, { moreToCome: true });
+      expect(readSpy).to.not.have.been.called;
+    });
   });
 
   describe('Connection - functional', function () {

test/integration/node-specific/mongo_client.test.ts

@@ -682,7 +682,7 @@ describe('class MongoClient', function () {
       expect(result2).to.have.property('ok', 1);
     });
 
-    it('sends endSessions with noResponse set', async () => {
+    it('sends endSessions with writeConcern w = 0 set', async () => {
       const session = client.startSession(); // make a session to be ended
       await client.db('test').command({ ping: 1 }, { session });
       await session.endSession();
@@ -698,7 +698,7 @@ describe('class MongoClient', function () {
       expect(startedEvents).to.have.lengthOf(1);
       expect(startedEvents[0]).to.have.property('commandName', 'endSessions');
       expect(endEvents).to.have.lengthOf(1);
-      expect(endEvents[0]).to.have.property('reply', undefined); // noReponse: true
+      expect(endEvents[0]).to.containSubset({ reply: { ok: 1 } }); // moreToCome = true
     });
 
     context('when server selection would return no servers', () => {

test/unit/cmap/connection.test.ts

@@ -28,29 +28,6 @@ describe('new Connection()', function () {
 
   before(() => mock.createServer().then(s => (server = s)));
 
-  it('supports fire-and-forget messages', async function () {
-    server.setMessageHandler(request => {
-      const doc = request.document;
-      if (isHello(doc)) {
-        request.reply(mock.HELLO);
-      }
-
-      // black hole all other requests
-    });
-
-    const options = {
-      ...connectionOptionsDefaults,
-      connectionType: Connection,
-      hostAddress: server.hostAddress(),
-      authProviders: new MongoClientAuthProviders()
-    };
-
-    const conn = await connect(options);
-    const readSpy = sinon.spy(conn, 'readMany');
-    await conn.command(ns('$admin.cmd'), { ping: 1 }, { noResponse: true });
-    expect(readSpy).to.not.have.been.called;
-  });
-
   it('destroys streams which time out', async function () {
     server.setMessageHandler(request => {
       const doc = request.document;

test/unit/collection.test.ts

@@ -14,55 +14,6 @@ describe('Collection', function () {
     await cleanup();
   });
 
-  context('#createIndex', () => {
-    it('should error when createIndex fails', function (done) {
-      const ERROR_RESPONSE = {
-        ok: 0,
-        errmsg:
-          'WiredTigerIndex::insert: key too large to index, failing  1470 { : "56f37cb8e4b089e98d52ab0e", : "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa..." }',
-        code: 17280
-      };
-
-      server.setMessageHandler(request => {
-        const doc = request.document;
-
-        if (isHello(doc)) {
-          return request.reply(Object.assign({}, HELLO));
-        }
-
-        if (doc.createIndexes) {
-          return request.reply(ERROR_RESPONSE);
-        }
-
-        if (doc.insert === 'system.indexes') {
-          return request.reply(ERROR_RESPONSE);
-        }
-      });
-
-      const client = new MongoClient(`mongodb://${server.uri()}`);
-
-      const close = e => client.close().then(() => done(e));
-
-      client
-        .connect()
-        .then(() => client.db('foo').collection('bar'))
-        .then(coll => coll.createIndex({ a: 1 }))
-        .then(
-          () => close('Expected createIndex to fail, but it succeeded'),
-          e => {
-            try {
-              expect(e).to.have.property('ok', ERROR_RESPONSE.ok);
-              expect(e).to.have.property('errmsg', ERROR_RESPONSE.errmsg);
-              expect(e).to.have.property('code', ERROR_RESPONSE.code);
-              close(null);
-            } catch (err) {
-              close(err);
-            }
-          }
-        );
-    });
-  });
-
   context('#aggregate', () => {
     // general test for aggregate function
     function testAggregate(config, done) {