Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-286235: Improved tooling (ESLint/Prettier) and GH actions #290

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

lovisaberggren
Copy link
Collaborator

@lovisaberggren lovisaberggren commented Nov 22, 2024

Proposed changes

  • Moving package.json to root for sharing between tools
  • Added Prettier and ESLint
  • Added GH workflow step for Prettier and ESLint

Jira ticket: CLOUDP-286235

Running locally:

# Reformat with Prettier
npm run format

# Run Prettier check (no reformat)
npm run format-check

# Run ESLint check (JS files)
npm run lint-js

Further comments

We can consider running the existing spectral linting with the package.json instead of a makefile (planned approach for new ipa validator)

@lovisaberggren lovisaberggren marked this pull request as ready for review November 22, 2024 17:58
@lovisaberggren lovisaberggren requested a review from a team as a code owner November 22, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant