DRIVERS-3021 Skip tests with errorCodeName on Serverless (#1680)

Skip tests on Atlas Serverless that expect a `codeName` from an error caused by a failpoint. Serverless may set an empty `codeName` due to CLOUDP-280424
mongodb · Oct 31, 2024 · 5f6fd28 · 5f6fd28
1 parent 9ad41a1
commit 5f6fd28
Show file tree

Hide file tree

Showing 6 changed files with 42 additions and 2 deletions.
diff --git a/source/transactions-convenient-api/tests/unified/commit-retry.json b/source/transactions-convenient-api/tests/unified/commit-retry.json
@@ -422,6 +422,11 @@
     },
     {
       "description": "commit is not retried after MaxTimeMSExpired error",
+      "runOnRequirements": [
+        {
+          "serverless": "forbid"
+        }
+      ],
       "operations": [
         {
           "name": "failPoint",

diff --git a/source/transactions-convenient-api/tests/unified/commit-retry.yml b/source/transactions-convenient-api/tests/unified/commit-retry.yml
@@ -212,6 +212,9 @@ tests:
           - { _id: 1 }
   -
     description: commit is not retried after MaxTimeMSExpired error
+    runOnRequirements:
+      # Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
+      - serverless: forbid
     operations:
       - name: failPoint
         object: testRunner

diff --git a/source/transactions-convenient-api/tests/unified/commit-writeconcernerror.json b/source/transactions-convenient-api/tests/unified/commit-writeconcernerror.json
@@ -1,6 +1,6 @@
 {
   "description": "commit-writeconcernerror",
-  "schemaVersion": "1.3",
+  "schemaVersion": "1.4",
   "runOnRequirements": [
     {
       "minServerVersion": "4.0",
@@ -414,6 +414,11 @@
     },
     {
       "description": "commitTransaction is not retried after UnknownReplWriteConcern error",
+      "runOnRequirements": [
+        {
+          "serverless": "forbid"
+        }
+      ],
       "operations": [
         {
           "name": "failPoint",
@@ -546,6 +551,11 @@
     },
     {
       "description": "commitTransaction is not retried after UnsatisfiableWriteConcern error",
+      "runOnRequirements": [
+        {
+          "serverless": "forbid"
+        }
+      ],
       "operations": [
         {
           "name": "failPoint",
@@ -678,6 +688,11 @@
     },
     {
       "description": "commitTransaction is not retried after MaxTimeMSExpired error",
+      "runOnRequirements": [
+        {
+          "serverless": "forbid"
+        }
+      ],
       "operations": [
         {
           "name": "failPoint",

diff --git a/source/transactions-convenient-api/tests/unified/commit-writeconcernerror.yml b/source/transactions-convenient-api/tests/unified/commit-writeconcernerror.yml
@@ -1,6 +1,6 @@
 description: commit-writeconcernerror
 
-schemaVersion: '1.3'
+schemaVersion: '1.4' # For `serverless` in `runOnRequirements`
 
 runOnRequirements:
   - minServerVersion: '4.0'
@@ -151,6 +151,9 @@ tests:
     outcome: *outcome
   -
     description: commitTransaction is not retried after UnknownReplWriteConcern error
+    runOnRequirements:
+      # Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
+      - serverless: forbid
     operations:
       - name: failPoint
         object: testRunner
@@ -203,6 +206,9 @@ tests:
     outcome: *outcome
   -
     description: commitTransaction is not retried after UnsatisfiableWriteConcern error
+    runOnRequirements:
+      # Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
+      - serverless: forbid
     operations:
       - name: failPoint
         object: testRunner
@@ -226,6 +232,9 @@ tests:
     outcome: *outcome
   -
     description: commitTransaction is not retried after MaxTimeMSExpired error
+    runOnRequirements:
+      # Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
+      - serverless: forbid
     operations:
       - name: failPoint
         object: testRunner

diff --git a/source/transactions/tests/unified/retryable-commit.json b/source/transactions/tests/unified/retryable-commit.json
diff --git a/source/transactions/tests/unified/retryable-commit.yml b/source/transactions/tests/unified/retryable-commit.yml
@@ -67,6 +67,9 @@ initialData:
 tests:
   -
     description: 'commitTransaction fails after Interrupted'
+    runOnRequirements:
+      # Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
+      - serverless: forbid
     operations:
       -
         object: testRunner