Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIVERS-2452 Add database name to the "command failed" and "command succeeded" log messages #1436

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

qingyang-hu
Copy link
Contributor

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded clusters, and serverless).

DRIVERS-2452
Add the database name to the "command failed" and "command succeeded" log messages.

@qingyang-hu qingyang-hu requested a review from a team as a code owner June 21, 2023 21:05
@qingyang-hu qingyang-hu requested review from dariakp and jmikola and removed request for a team June 21, 2023 21:05
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take my review with a grain of salt as I haven't worked on the logging spec and don't have an implementation I can use to POC this.

@@ -52,13 +52,14 @@ tests:
component: command
data:
message: "Command succeeded"
databaseName: *databaseName
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted that the schema defines data as an object (here), so a new field here has no impact on the schema version.

Check unified test format files against schema / build (pull_request)

Copy link
Contributor

@BorisDog BorisDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified that the test works in .NET.

@qingyang-hu qingyang-hu merged commit 6b267dd into mongodb:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants