Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRIVERS-2675: Remove use of "sharded-replicaset" #1443

Merged
merged 1 commit into from
Jul 19, 2023
Merged

DRIVERS-2675: Remove use of "sharded-replicaset" #1443

merged 1 commit into from
Jul 19, 2023

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Jul 17, 2023 •
edited
Loading

https://jira.mongodb.org/browse/DRIVERS-2675

Although one test does not specify a minServerVersion, "sharded-replicaset" is still redundant since $readPreference is always sent to mongos.

  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded clusters, and serverless).

@jmikola
DRIVERS-2675: Remove use of "sharded-replicaset"
1cdeddd 
Although one test does not specify a minServerVersion, "sharded-replicaset" is still redundant since $readPreference is always sent to mongos.
@jmikola jmikola requested a review from nbbeeken July 17, 2023 16:56
@jmikola jmikola requested a review from a team as a code owner July 17, 2023 16:56
@jmikola jmikola requested review from dariakp and removed request for a team July 17, 2023 16:56
@jmikola jmikola mentioned this pull request Jul 17, 2023
Merged
@jmikola
Copy link
Member Author

jmikola commented Jul 19, 2023

PHPLIB patch build succeeded, so I'll proceed with merging.

@jmikola jmikola merged commit 9d7ceed into mongodb:master Jul 19, 2023
3 checks passed
@jmikola jmikola deleted the drivers-2675 branch July 19, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

@dariakp dariakp dariakp approved these changes

@nbbeeken nbbeeken Awaiting requested review from nbbeeken

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmikola @alcaeus @dariakp