Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIVERS-2384 FaaS testing spec clarifications #1445

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Jul 26, 2023

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded clusters, and serverless).

@blink1073 blink1073 requested a review from a team as a code owner July 26, 2023 13:20
@blink1073 blink1073 requested review from jyemin and durran and removed request for a team July 26, 2023 13:20
@jmikola
Copy link
Member

jmikola commented Jul 28, 2023

@blink1073: I suggest revising the PR title or commit message before merging so there's more context when viewing the repository history. For example:

DRIVERS-2384 FaaS testing spec clarifications

@blink1073 blink1073 changed the title DRIVERS-2384 Clarifications DRIVERS-2384 FaaS testing spec clarifications Jul 28, 2023
@blink1073
Copy link
Member Author

FaaS testing spec clarifications

Done!

@blink1073
Copy link
Member Author

ping @durran for final approval

@durran durran merged commit b8a5a00 into mongodb:master Aug 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants