Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIVERS-2687 Add BSON Binary Data subtype Sensitive #1446

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

NoahStapp
Copy link
Contributor

The new test validates only the correct subtype, number encoding/decoding, and binary data encoding/decoding. Any binary data itself is not validated. DRIVERS-2687 specifies that data using this subtype is meant to not be logged, so this should satisfy testing requirements.

@NoahStapp NoahStapp requested a review from a team as a code owner August 1, 2023 19:12
@NoahStapp NoahStapp requested review from dariakp and removed request for a team August 1, 2023 19:12
@dariakp dariakp requested a review from blink1073 August 1, 2023 19:35
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NoahStapp NoahStapp merged commit db7eb39 into mongodb:master Aug 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants