DRIVERS-1571 Retry on different mongos when possible #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbevi
reviewed
Aug 16, 2023
alexbevi
reviewed
Aug 16, 2023
Co-authored-by: Alex Bevilacqua <alex@alexbevi.com>
Co-authored-by: Alex Bevilacqua <alex@alexbevi.com>
prestonvasquez
requested changes
Aug 16, 2023
Co-authored-by: Preston Vasquez <prestonvasquez@icloud.com>
Co-authored-by: Preston Vasquez <prestonvasquez@icloud.com>
Co-authored-by: Preston Vasquez <prestonvasquez@icloud.com>
Co-authored-by: Preston Vasquez <prestonvasquez@icloud.com>
Co-authored-by: Preston Vasquez <prestonvasquez@icloud.com>
Co-authored-by: Preston Vasquez <prestonvasquez@icloud.com>
Co-authored-by: Preston Vasquez <prestonvasquez@icloud.com>
Co-authored-by: Preston Vasquez <prestonvasquez@icloud.com>
Co-authored-by: Preston Vasquez <prestonvasquez@icloud.com>
Co-authored-by: Preston Vasquez <prestonvasquez@icloud.com>
Co-authored-by: Preston Vasquez <prestonvasquez@icloud.com>
Co-authored-by: Preston Vasquez <prestonvasquez@icloud.com>
Co-authored-by: Preston Vasquez <prestonvasquez@icloud.com>
Co-authored-by: Preston Vasquez <prestonvasquez@icloud.com>
comandeo
requested review from
patrickfreed and
kkloberdanz
and removed request for
a team
prestonvasquez
approved these changes
Aug 22, 2023
|
|
||
| 2. Create a client per mongos using the direct connection, and configure fail | ||
| points on each of the picked mongoses, so that each mongos raises | ||
| a retryable error once. |
There was a problem hiding this comment.
Should we include that the failpoint should be configured with a "RetryableWriteError" label?
There was a problem hiding this comment.
Good point! Added errorLabels: ['RetryableWriteError'] to the failpoint specification above.
| mongoses in the cluster, pick one to test against. | ||
|
|
||
| 2. Create a client that connects to the mongos using the direct connection, | ||
| and configure a fail point so that the mongos raises a retryable error once. |
There was a problem hiding this comment.
Should we include that the failpoint should be configured with a "RetryableWriteError" label?
Co-authored-by: Preston Vasquez <prestonvasquez@icloud.com>
kkloberdanz
approved these changes
Aug 25, 2023
alexbevi
approved these changes
Aug 25, 2023
Co-authored-by: Alex Bevilacqua <alex@alexbevi.com>
Co-authored-by: Alex Bevilacqua <alex@alexbevi.com>
Co-authored-by: Alex Bevilacqua <alex@alexbevi.com>
Co-authored-by: Alex Bevilacqua <alex@alexbevi.com>
Co-authored-by: Alex Bevilacqua <alex@alexbevi.com>
Co-authored-by: Alex Bevilacqua <alex@alexbevi.com>
Co-authored-by: Alex Bevilacqua <alex@alexbevi.com>
Co-authored-by: Alex Bevilacqua <alex@alexbevi.com>
Co-authored-by: Alex Bevilacqua <alex@alexbevi.com>
Co-authored-by: Alex Bevilacqua <alex@alexbevi.com>
vector-of-bool
approved these changes
Aug 25, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please complete the following before merging:
Ruby PoC - mongodb/mongo-ruby-driver#2717
Go PoC - mongodb/mongo-go-driver#1358