Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync retryable reads with SDAM #1453

Merged

Conversation

prestonvasquez
Copy link
Contributor

This PR proposes a re-phrasing of the "Why are read operations only retried once by default?" section of retryable reads to fix inconsistencies between the retryable reads and SDAM specifications. From the retryable reads Q&A on why read operations are only retried once:

In the case of a transient error, the driver will mark the server as “unknown” per the SDAM spec.

From the SDAM rationale for “Other transient errors” :

There are other transient errors a server may return, e.g. retryable errors listed in the retryable writes spec. SDAM does not consider these because they do not imply the connected server should be marked as “Unknown”.

  • Update changelog.
    - [ ] Make sure there are generated JSON files from the YAML test files.
    - [ ] Test changes in at least one language driver.
    - [ ] Test these changes against all server versions and topologies (including standalone, replica set, sharded clusters, and serverless).

@prestonvasquez prestonvasquez requested a review from a team as a code owner August 21, 2023 23:44
@prestonvasquez prestonvasquez requested review from kkloberdanz and removed request for a team August 21, 2023 23:44
@prestonvasquez prestonvasquez merged commit 3ff3800 into mongodb:master Aug 22, 2023
3 checks passed
@prestonvasquez prestonvasquez deleted the sync-retryable-reads-with-sdam branch August 22, 2023 19:40
@ShaneHarvey
Copy link
Member

Thanks Preston!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants