Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRIVERS-2570 Report docker or kubernetes environment in handshake #1454

Merged
merged 5 commits into from
Aug 28, 2023
Merged

DRIVERS-2570 Report docker or kubernetes environment in handshake #1454

merged 5 commits into from
Aug 28, 2023

Conversation

abr-egn
Copy link
Contributor

@abr-egn abr-egn commented Aug 25, 2023

Please complete the following before merging:

  • [✓] Update changelog.
  • [n/a] Make sure there are generated JSON files from the YAML test files.
  • [✓] Test changes in at least one language driver.
  • [✓] Test these changes against all server versions and topologies (including standalone, replica set, sharded clusters, and serverless).

mongodb/mongo-rust-driver#940 implements this in the Rust driver.

@abr-egn abr-egn requested a review from a team as a code owner August 25, 2023 14:14
@abr-egn abr-egn requested review from alcaeus and removed request for a team August 25, 2023 14:14
@abr-egn abr-egn changed the title RUST-1703 Add docker and kubernetes metrics DRIVERS-2570 Report docker or kubernetes environment in handshake Aug 25, 2023
alcaeus
alcaeus requested changes Aug 28, 2023
View reviewed changes
source/mongodb-handshake/handshake.rst Outdated Show resolved Hide resolved
source/mongodb-handshake/handshake.rst Outdated Show resolved Hide resolved
source/mongodb-handshake/handshake.rst Show resolved Hide resolved
abr-egn and others added 2 commits August 28, 2023 08:51
@abr-egn @alcaeus
Update source/mongodb-handshake/handshake.rst
bcb5bbb 
Co-authored-by: Andreas Braun <alcaeus@users.noreply.github.com>
@abr-egn @alcaeus
Update source/mongodb-handshake/handshake.rst
c4831b4 
Co-authored-by: Andreas Braun <alcaeus@users.noreply.github.com>
@abr-egn abr-egn requested a review from alcaeus August 28, 2023 12:51
@abr-egn abr-egn merged commit 611ecb5 into mongodb:master Aug 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abr-egn @alcaeus