DRIVERS-2672 Update unified test format to support OIDC tests. #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewdale
force-pushed
the
drivers2672-oidc-spec-tests
branch
3 times, most recently
from
4ef1872
to
bc78b17
Compare
matthewdale
force-pushed
the
drivers2672-oidc-spec-tests
branch
from
bc78b17
to
fff9888
Compare
durran
reviewed
Oct 17, 2023
| @@ -459,6 +459,14 @@ The structure of this object is as follows: | |||
| is enabled. If false, tests MUST NOT run if authentication is enabled. If this | |||
| field is omitted, there is no authentication requirement. | |||
|
|
|||
| - ``authMechanism``: Optional string. Specifies an authentication mechanism that | |||
There was a problem hiding this comment.
How are we expected to determine this? Wire version? saslSupportedMechs?
There was a problem hiding this comment.
db.adminCommand({'getParameter':"1", "authenticationMechanisms": "1"}). In PyMongo we actually already retrieved and stored all of the server parameters, so we can just look up authenticationMechanisms in that dict
|
These changes are now part of #1471. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRIVERS-2672
Please complete the following before merging: