DRIVERS-1389 Make ExceededTimeLimit a retryable reads error #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror codes that should receive a RetryableReadError label
kkloberdanz
requested review from
isabelatkinson,
kevinAlbs and
a team
and removed request for
a team
jmikola
reviewed
Nov 29, 2023
Co-authored-by: Jeremy Mikola <jmikola@gmail.com>
kevinAlbs
reviewed
Nov 29, 2023
There was a problem hiding this comment.
Test passes in the Go driver: https://spruce.mongodb.com/version/656776023627e0d2079bcbbc
The Go driver already considers error 262 a retryable read and does not need changes to pass this test.
Co-authored-by: Kevin Albertson <kevin.albertson@10gen.com>
|
Thanks everyone for the reviews. I've implemented the suggestions, and the PR is ready for another round of review. |
isabelatkinson
approved these changes
Nov 29, 2023
jmikola
approved these changes
Nov 30, 2023
|
|
||
| schemaVersion: "1.3" | ||
|
|
||
| runOnRequirements: |
There was a problem hiding this comment.
Noted that these requirements are consistent with the legacy tests in https://github.com/mongodb/specifications/blob/master/source/retryable-reads/tests/legacy/find.yml
Co-authored-by: Jeremy Mikola <jmikola@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please complete the following before merging:
See the C Driver implementation for reference.