DRIVERS-926 Make ReadConcernMajorityNotAvailableYet a retryable read error #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkloberdanz
commented
Dec 1, 2023
| NotPrimaryNoSecondaryOk 13435 | ||
| NotPrimaryOrSecondary 13436 | ||
| PrimarySteppedDown 189 | ||
| ReadConcernMajorityNotAvailableYet 134 |
There was a problem hiding this comment.
Note: The error named ReadConcernMajorityNotAvailableYet is longer than any existing errors in this list, so I needed to resize the table to fit it in, hence why the diff shows the entire table has changed rather than this single line.
There was a problem hiding this comment.
In these cases the "Hide whitespace" changes checkbox is really useful.
kkloberdanz
force-pushed
the
DRIVERS-926
branch
from
ae1f53d
to
cb8e6b7
Compare
kkloberdanz
requested review from
isabelatkinson,
kevinAlbs and
ShaneHarvey
and removed request for
a team
kevinAlbs
approved these changes
Dec 1, 2023
ShaneHarvey
requested changes
Dec 1, 2023
| @@ -704,6 +705,8 @@ degraded performance can simply disable ``retryableReads``. | |||
| Changelog | |||
| ========= | |||
|
|
|||
| :2023-11-30: Add to ReadConcernMajorityNotAvailableYet the list of error codes | |||
There was a problem hiding this comment.
🤦♂️ Thanks for catching that grammar error!
ShaneHarvey
approved these changes
Dec 1, 2023
isabelatkinson
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please complete the following before merging:
See the C Driver implementation for reference.