Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRIVERS-2170 Server info on retryable errors must reflect the originating server #1480

Merged
merged 4 commits into from
Jan 9, 2024
Merged

DRIVERS-2170 Server info on retryable errors must reflect the originating server #1480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
59ec7d9
DRIVERS-2170 server info on retryable errors must reflect originating…
jamis Dec 5, 2023
686f8e6
update changelogs
jamis Dec 5, 2023
2dccf6f
simplify the paragraph
jamis Dec 15, 2023
028b928
Merge branch 'master' into drivers-2170-retryable-errors-and-originat…
jamis Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions source/retryable-reads/retryable-reads.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,10 @@ other error originating from the server, that error should be raised instead as
the caller can infer that an attempt was made and the second error is likely
more relevant (with respect to the current topology state).

If a driver associates server information (e.g. the server address or
description) with an error, the driver MUST ensure that the reported server
information corresponds to the server that originated the error.

4. Implementation constraints
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Expand Down Expand Up @@ -705,6 +709,9 @@ degraded performance can simply disable ``retryableReads``.
Changelog
=========

:2023-12-05: Add that any server information associated with retryable
exceptions MUST reflect the originating server, even in the
presence of retries.
:2023-11-30: Add ReadConcernMajorityNotAvailableYet to the list of error codes
that should be retried.
:2023-11-28: Add ExceededTimeLimit to the list of error codes that should
Expand Down
7 changes: 7 additions & 0 deletions source/retryable-writes/retryable-writes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,10 @@ from the driver) or the error is labeled "NoWritesPerformed", the error from
the previous attempt should be raised. If all server errors are labeled
"NoWritesPerformed", then the first error should be raised.

If a driver associates server information (e.g. the server address or
description) with an error, the driver MUST ensure that the reported server
information corresponds to the server that originated the error.

The above rules are implemented in the following pseudo-code:

.. code-block:: typescript
Expand Down Expand Up @@ -851,6 +855,9 @@ Changelog
=========

:2023-12-06: Clarify that writes are not retried within transactions.
:2023-12-05: Add that any server information associated with retryable
exceptions MUST reflect the originating server, even in the
presence of retries.
:2023-10-02: When CSOT is not enabled, one retry attempt occurs.
:2023-08-26: Require that in a sharded cluster the server on which the
operation failed MUST be provided to the server selection
Expand Down
Loading