DRIVERS-2799: Use more permissive top-level runOnRequirements #1484
+53
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids unintentionally skipping tests. Previously, some tests were never run on sharded clusters.
This ensures the unified test is consistent with the legacy test from which it was derived. Additionally, it makes the test resilient to possible changes in DRIVERS-1641. This inconsistency dates back to e4808b8.
jmikola
requested review from
alcaeus and
kkloberdanz
and removed request for
a team
alcaeus
approved these changes
Dec 19, 2023
kkloberdanz
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/DRIVERS-2799
This also fixes an outstanding inconsistency in one of the retryable writes POC tests for the unified test runner, which would otherwise start failing once DRIVERS-1641 is implemented.
PHPLIB POC: mongodb/mongo-php-library#1210
Please complete the following before merging: