-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRIVERS-2790 Add codespell checker #1491
Conversation
rev: "v2.2.6" | ||
hooks: | ||
- id: codespell | ||
args: ["-L", "fle,re-use,merchantibility,synching,crate,nin,infinit,te"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"merchantability" is a misspelling of "merchantability", but I suppose most of this is required for LICENSE.md
.
@@ -54,7 +54,7 @@ | |||
"key_vault_data": [], | |||
"tests": [ | |||
{ | |||
"description": "FLE2 encrypt fails with mising key", | |||
"description": "FLE2 encrypt fails with missing key", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remember to make a note of any changed spec tests when entering downstream changes for DRIVERS-2780. It's possible that drivers depend on existing test names for custom skip logic, in which case some updates may be required (languages can always ignore syncing if they like).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The underlying ticket is closed, and I don't see the word mising
used in this org. Do you think it is worth opening a new ticket? Or perhaps ignoring mising
in this PR and making a new ticket?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If "mising" isn't used anywhere in the org I think we can just ignore this. Good idea running a search.
I also didn't consider the DRIVERS ticket would have already been triaged, and past the stage to denote driver changes.
Please complete the following before merging:
clusters, and serverless).