Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIVERS-2790 Add codespell checker #1491

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Conversation

blink1073
Copy link
Member

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

@blink1073 blink1073 requested review from a team as code owners January 9, 2024 12:24
@blink1073 blink1073 requested review from jmikola, comandeo, vector-of-bool, jess-sig, baileympearson, abr-egn and dariakp and removed request for a team January 9, 2024 12:24
rev: "v2.2.6"
hooks:
- id: codespell
args: ["-L", "fle,re-use,merchantibility,synching,crate,nin,infinit,te"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"merchantability" is a misspelling of "merchantability", but I suppose most of this is required for LICENSE.md.

@@ -54,7 +54,7 @@
"key_vault_data": [],
"tests": [
{
"description": "FLE2 encrypt fails with mising key",
"description": "FLE2 encrypt fails with missing key",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remember to make a note of any changed spec tests when entering downstream changes for DRIVERS-2780. It's possible that drivers depend on existing test names for custom skip logic, in which case some updates may be required (languages can always ignore syncing if they like).

Copy link
Member Author

@blink1073 blink1073 Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The underlying ticket is closed, and I don't see the word mising used in this org. Do you think it is worth opening a new ticket? Or perhaps ignoring mising in this PR and making a new ticket?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If "mising" isn't used anywhere in the org I think we can just ignore this. Good idea running a search.

I also didn't consider the DRIVERS ticket would have already been triaged, and past the stage to denote driver changes.

@blink1073 blink1073 merged commit e9ae09d into mongodb:master Jan 11, 2024
4 checks passed
@blink1073 blink1073 deleted the spellcheck branch January 11, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants