Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIVERS-2802: Fix insertedId expectations in insertOne-errorLabels #1494

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Jan 11, 2024

https://jira.mongodb.org/browse/DRIVERS-2802

This corrects a mistake introduced in 5fc23f4 when these tests were originally moved from insertOne-serverErrors

This was missed in the POC for #1489 since libmongoc doesn't report inserted IDs (see: json-test-operations.c).

POC for this change: mongodb/mongo-php-library#1214

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

This corrects a mistake introduced in 5fc23f4 when these tests were originally moved from insertOne-serverErrors
@jmikola jmikola requested a review from a team as a code owner January 11, 2024 16:33
@jmikola jmikola requested review from kkloberdanz and removed request for a team January 11, 2024 16:33
@jmikola jmikola merged commit 8de8180 into mongodb:master Jan 12, 2024
4 checks passed
@jmikola jmikola deleted the drivers-2802 branch January 12, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants