-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRIVERS-2732 CSFLE/QE KMIP support for encrypt/decrypt #1507
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Suggest removing one of the delegated
options to simplify the interface.
I suggest waiting until corresponding drivers-evergreen-tools changes (for new KMIP key?), libmongocrypt changes, and C driver changes are approved before merging. The reviews for those changes may reveal required test changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one additional spec update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The client-side-encryption.rst file was recently converted to markdown as part of DRIVERS-2789. client-side-encryption.rst now has this note:
This specification has been converted to Markdown and renamed to
client-side-encryption.md <client-side-encryption.md>
_.
Use the link above to access the latest version of the specification as the
current reStructuredText file will no longer be updated.
Prior to merging, apply the changes to the markdown file and revert the reStructuredText changes.
Co-authored-by: Kevin Albertson <kevin.albertson@10gen.com>
02aba78
to
8dfafc6
Compare
0efa9a5
to
ba145d3
Compare
Please complete the following before merging:
clusters, and serverless).