Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIVERS-2732 CSFLE/QE KMIP support for encrypt/decrypt #1507

Merged
merged 14 commits into from
Mar 25, 2024

Conversation

adriandole
Copy link
Contributor

@adriandole adriandole commented Feb 8, 2024

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver. C implementation
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

@adriandole adriandole marked this pull request as ready for review February 9, 2024 08:34
@adriandole adriandole requested a review from a team as a code owner February 9, 2024 08:34
@adriandole adriandole requested review from katcharov and kevinAlbs and removed request for a team February 9, 2024 08:34
@adriandole adriandole requested a review from a team as a code owner February 10, 2024 01:02
Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Suggest removing one of the delegated options to simplify the interface.

I suggest waiting until corresponding drivers-evergreen-tools changes (for new KMIP key?), libmongocrypt changes, and C driver changes are approved before merging. The reviews for those changes may reveal required test changes.

flake.nix Outdated Show resolved Hide resolved
source/client-side-encryption/client-side-encryption.rst Outdated Show resolved Hide resolved
source/client-side-encryption/client-side-encryption.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one additional spec update.

source/client-side-encryption/client-side-encryption.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@katcharov katcharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The client-side-encryption.rst file was recently converted to markdown as part of DRIVERS-2789. client-side-encryption.rst now has this note:

This specification has been converted to Markdown and renamed to
client-side-encryption.md <client-side-encryption.md>_.
Use the link above to access the latest version of the specification as the
current reStructuredText file will no longer be updated.

Prior to merging, apply the changes to the markdown file and revert the reStructuredText changes.

@adriandole adriandole merged commit 57b77d8 into mongodb:master Mar 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants