Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRIVERS-2416 Add Azure built-in integration for OIDC. #1513

Merged
merged 9 commits into from
Mar 21, 2024
Merged

DRIVERS-2416 Add Azure built-in integration for OIDC. #1513

merged 9 commits into from
Mar 21, 2024

Conversation

matthewdale
Copy link
Contributor

@matthewdale matthewdale commented Feb 13, 2024 •
edited
Loading

DRIVERS-2416

Specify the behavior of the OIDC provider integration on Azure VMs.

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

@matthewdale matthewdale force-pushed the drivers2416-oidc-azure branch 2 times, most recently from abe1db2 to a8363fd Compare February 21, 2024 21:12
@matthewdale matthewdale marked this pull request as ready for review February 21, 2024 22:21
@matthewdale matthewdale requested a review from a team as a code owner February 21, 2024 22:21
@matthewdale matthewdale requested review from comandeo-mongo and blink1073 and removed request for a team February 21, 2024 22:21
katcharov
katcharov requested changes Feb 22, 2024
View reviewed changes
source/auth/auth.md Outdated Show resolved Hide resolved
source/auth/auth.md Outdated Show resolved Hide resolved
source/auth/auth.md Outdated Show resolved Hide resolved
source/auth/auth.md Outdated Show resolved Hide resolved
source/auth/auth.md Outdated Show resolved Hide resolved
@matthewdale @katcharov
Apply suggestions from code review
66af2eb 
Co-authored-by: Maxim Katcharov <maxim.katcharov@mongodb.com>
durran
durran reviewed Feb 28, 2024
View reviewed changes
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment from me since we're doing this in the Node driver already. Should we make a note somewhere that the unified tests should be run against Azure?

@blink1073
Copy link
Member

Should we make a note somewhere that the unified tests should be run against Azure?

Done, and added Azure-specific prose tests.
Note that we'll need to wait until #1544 is merged to ensure everything is coherent with the new naming before merging this PR.

katcharov
katcharov reviewed Mar 12, 2024
View reviewed changes
source/auth/auth.md Outdated Show resolved Hide resolved
@durran durran mentioned this pull request Mar 15, 2024
Merged
5 tasks
katcharov
katcharov approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@katcharov katcharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blink1073 blink1073 merged commit 2c3be08 into mongodb:master Mar 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran left review comments

@katcharov katcharov katcharov approved these changes

@comandeo-mongo comandeo-mongo Awaiting requested review from comandeo-mongo comandeo-mongo is a code owner automatically assigned from mongodb/dbx-spec-owners-auth

@blink1073 blink1073 Awaiting requested review from blink1073

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthewdale @blink1073 @durran @katcharov