-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRIVERS-2789 Convert GridFS Spec to Markdown #1529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments, but LGTM once the table formatting is fixed.
source/gridfs/gridfs-spec.md
Outdated
the file"s data, stored as a hex string, if computed, otherwise omitted. | | filename | the filename passed to this | ||
function, UTF-8 encoded. | | contenttype | the "contentType" passed in the options, if provided; otherwise omitted. | | | ||
aliases | the array passed in the options, if provided; otherwise omitted. | | metadata | the "metadata" document passed | ||
in the options, if provided; otherwise omitted. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting for this table is off. Looks like you're missing newlines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
599e5cf
to
3d057fc
Compare
Remove old readme Update source/gridfs/gridfs-spec.md Co-authored-by: Jeremy Mikola <jmikola@gmail.com> address review
3d057fc
to
c717bf3
Compare
Please complete the following before merging:
clusters, and serverless).