Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIVERS-2789 Convert GridFS Spec to Markdown #1529

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

blink1073
Copy link
Member

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

@blink1073 blink1073 requested review from a team as code owners February 27, 2024 12:52
@blink1073 blink1073 requested review from jmikola, dariakp and ShaneHarvey and removed request for a team, jmikola and dariakp February 27, 2024 12:52
source/retryable-reads/tests/README.rst Show resolved Hide resolved
source/gridfs/gridfs-spec.md Show resolved Hide resolved
source/gridfs/gridfs-spec.md Show resolved Hide resolved
source/gridfs/gridfs-spec.md Show resolved Hide resolved
source/gridfs/gridfs-spec.md Outdated Show resolved Hide resolved
source/gridfs/gridfs-spec.md Show resolved Hide resolved
source/gridfs/gridfs-spec.md Outdated Show resolved Hide resolved
source/gridfs/gridfs-spec.md Show resolved Hide resolved
source/gridfs/gridfs-spec.md Show resolved Hide resolved
@blink1073 blink1073 requested a review from jmikola March 4, 2024 12:11
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments, but LGTM once the table formatting is fixed.

the file"s data, stored as a hex string, if computed, otherwise omitted. | | filename | the filename passed to this
function, UTF-8 encoded. | | contenttype | the "contentType" passed in the options, if provided; otherwise omitted. | |
aliases | the array passed in the options, if provided; otherwise omitted. | | metadata | the "metadata" document passed
in the options, if provided; otherwise omitted. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting for this table is off. Looks like you're missing newlines.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

source/index.md Show resolved Hide resolved
Remove old readme

Update source/gridfs/gridfs-spec.md

Co-authored-by: Jeremy Mikola <jmikola@gmail.com>

address review
@blink1073 blink1073 merged commit 19c3355 into mongodb:master Mar 5, 2024
4 checks passed
@blink1073 blink1073 deleted the DRIVERS-2789-gridfs branch March 5, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants