Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRIVERS-1711: Convert retryable writes spec tests to unified test format #1530

Merged
merged 13 commits into from
Mar 1, 2024
Merged

DRIVERS-1711: Convert retryable writes spec tests to unified test format #1530

merged 13 commits into from
Mar 1, 2024

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Feb 28, 2024 •
edited
Loading

https://jira.mongodb.org/browse/DRIVERS-1711

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded clusters, and serverless).

POC: mongodb/mongo-php-library#1238

jmikola added a commit to jmikola/mongo-php-library that referenced this pull request Feb 28, 2024
@jmikola
wip Sync retryable writes spec tests for POC
24d77d5 
Synced with mongodb/specifications#1530
@jmikola jmikola mentioned this pull request Feb 28, 2024
Merged
@jmikola jmikola marked this pull request as ready for review February 28, 2024 04:35
@jmikola jmikola requested review from a team as code owners February 28, 2024 04:35
@jmikola jmikola requested review from alcaeus and kkloberdanz and removed request for a team February 28, 2024 04:35
@jyemin jyemin self-requested a review February 29, 2024 13:36
jyemin
jyemin reviewed Feb 29, 2024
View reviewed changes
Copy link
Contributor

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried these on Java driver. Easy to get running, but two tests are failing on 4.2 replica set and 22 on 4.4 sharded. Still investigating.

@jyemin jyemin self-requested a review February 29, 2024 21:01
jyemin
jyemin approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figured out root cause of the test failures and they are unrelated to the conversion process.

LGTM

alcaeus
alcaeus approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @jmikola!

@jmikola jmikola merged commit 2c080e8 into mongodb:master Mar 1, 2024
4 checks passed
@jmikola jmikola deleted the drivers-1711 branch March 1, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyemin jyemin jyemin approved these changes

@alcaeus alcaeus alcaeus approved these changes

@kkloberdanz kkloberdanz Awaiting requested review from kkloberdanz kkloberdanz is a code owner automatically assigned from mongodb/dbx-spec-owners-retryability

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmikola @alcaeus @jyemin