DRIVERS-1690: Convert CRUD v1 tests to unified format #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since aggregate.yml, bulkWrite-arrayFilters.yml, and find.yml already existed, converted tests were incorporated into the existing file and changed as needed to account for differences in the existing file's initialData section.
This was leftover from porting the CRUD v2 tests in 68bf3b3 for DRIVERS-1130.
|
@jyemin: Would you like to POC these in Java as well? |
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Mar 1, 2024
jyemin
approved these changes
Mar 1, 2024
|
@nbbeeken: Do you still want to review this? If not, please remove yourself. |
alcaeus
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/DRIVERS-1690
Please complete the following before merging:
POC: mongodb/mongo-php-library#1240