Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIVERS-2789 Replace curly quotes with regular quotes #1535

Merged

Conversation

blink1073
Copy link
Member

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

@blink1073 blink1073 requested a review from jmikola March 4, 2024 12:08
@blink1073 blink1073 requested review from a team as code owners March 4, 2024 12:08
@blink1073 blink1073 requested review from baileympearson, abr-egn, comandeo-mongo, dariakp and a team and removed request for a team, baileympearson, abr-egn, comandeo-mongo and dariakp March 4, 2024 12:08
@@ -38,7 +38,7 @@ of precision, a max value of approximately `10^6145`, and min value of approxima
`BSON Decimal128` type (`"\x13"`).

**Clamping**:\
Clamping happens when a values exponent is too large for the destination format. This works by adding
Clamping happens when a value"s exponent is too large for the destination format. This works by adding
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops this should be ' not ".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like everything in the PR is replacing single curly quotes with a ".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@blink1073 blink1073 merged commit b27544b into mongodb:master Mar 5, 2024
4 checks passed
@blink1073 blink1073 deleted the DRIVERS-2789-handle-curly-quotes branch March 5, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants