Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRIVERS-2855: Convert default write concern tests to unified format #1547

Merged
merged 2 commits into from
Mar 12, 2024
Merged

DRIVERS-2855: Convert default write concern tests to unified format #1547

merged 2 commits into from
Mar 12, 2024

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Mar 12, 2024 •
edited
Loading

https://jira.mongodb.org/browse/DRIVERS-2855

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded clusters, and serverless).

POC: mongodb/mongo-php-library#1252

@jmikola jmikola requested review from a team as code owners March 12, 2024 02:31
@jmikola jmikola requested review from alcaeus and removed request for a team March 12, 2024 02:31
jmikola added a commit to jmikola/mongo-php-library that referenced this pull request Mar 12, 2024
@jmikola
PHPLIB-1409: Convert default write concern tests to unified test format
ce238d4 
Synced with mongodb/specifications#1547
@jmikola jmikola mentioned this pull request Mar 12, 2024
Merged
alcaeus
alcaeus approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor note on test location.

source/read-write-concern/tests/operation/default-write-concern-2.6.json Show resolved Hide resolved
@jmikola
Copy link
Member Author

jmikola commented Mar 12, 2024

Note: link check will be fixed by #1549

@jmikola
Copy link
Member Author

jmikola commented Mar 12, 2024

@jyemin: Do you want to POC this in Java before I merge?

@jyemin
Copy link
Contributor

jyemin commented Mar 12, 2024

Risk seems low on these so go ahead without me.

@jmikola jmikola merged commit bfb6a84 into mongodb:master Mar 12, 2024
4 checks passed
@jmikola jmikola deleted the drivers-2855 branch March 12, 2024 17:46
@jmikola jmikola mentioned this pull request Mar 13, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmikola @jyemin @alcaeus