Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRIVERS-2878 OIDC Atlas Testing Updates #1558

Merged
merged 6 commits into from
Apr 3, 2024
Merged

DRIVERS-2878 OIDC Atlas Testing Updates #1558

merged 6 commits into from
Apr 3, 2024

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Mar 29, 2024 •
edited
Loading

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver. PYTHON-4309 OIDC Atlas Testing Updates mongo-python-driver#1567
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

@blink1073 blink1073 marked this pull request as ready for review March 29, 2024 18:45
@blink1073 blink1073 requested a review from a team as a code owner March 29, 2024 18:45
@blink1073 blink1073 requested review from comandeo-mongo, durran and katcharov and removed request for a team and comandeo-mongo March 29, 2024 18:45
katcharov
katcharov requested changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@katcharov katcharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just minor clarifications

source/auth/tests/mongodb-oidc.md Outdated Show resolved Hide resolved
source/auth/tests/mongodb-oidc.md Outdated Show resolved Hide resolved
blink1073 and others added 3 commits April 2, 2024 19:38
@blink1073 blink1073 requested a review from katcharov April 3, 2024 00:58
katcharov
katcharov approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@katcharov katcharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blink1073 blink1073 merged commit fa9a05a into mongodb:master Apr 3, 2024
4 checks passed
@blink1073 blink1073 deleted the DRIVERS-2878 branch April 3, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katcharov katcharov katcharov approved these changes

@durran durran durran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blink1073 @durran @katcharov