Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRIVERS-2769 Clarify not validating saslSupportedMechs #1565

Merged
merged 5 commits into from
Apr 22, 2024
Merged

DRIVERS-2769 Clarify not validating saslSupportedMechs #1565

merged 5 commits into from
Apr 22, 2024

Conversation

comandeo-mongo
Copy link
Contributor

@comandeo-mongo comandeo-mongo commented Apr 11, 2024 •
edited
Loading

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files. - N/A
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

Ruby PoC - mongodb/mongo-ruby-driver#2858

@comandeo-mongo comandeo-mongo marked this pull request as ready for review April 15, 2024 07:52
@comandeo-mongo comandeo-mongo requested review from a team as code owners April 15, 2024 07:53
@comandeo-mongo comandeo-mongo requested review from blink1073 and removed request for a team April 15, 2024 07:53
JamesKovacs
JamesKovacs approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@JamesKovacs JamesKovacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

blink1073
blink1073 approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@comandeo-mongo comandeo-mongo merged commit b1e0274 into mongodb:master Apr 22, 2024
4 checks passed
@comandeo-mongo comandeo-mongo deleted the 2769-add-tests-for-SaslSupportedMechanisms branch April 22, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

@alcaeus alcaeus alcaeus approved these changes

@JamesKovacs JamesKovacs JamesKovacs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@comandeo-mongo @JamesKovacs @alcaeus @blink1073