Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRIVERS-2601 Fix API description for GCP built-in OIDC provider #1567

Merged
merged 1 commit into from
Apr 23, 2024
Merged

DRIVERS-2601 Fix API description for GCP built-in OIDC provider #1567

merged 1 commit into from
Apr 23, 2024

Conversation

blink1073
Copy link
Member

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

@blink1073 blink1073 requested a review from a team as a code owner April 23, 2024 00:53
@blink1073 blink1073 requested review from comandeo-mongo and removed request for a team and comandeo-mongo April 23, 2024 00:53
@blink1073
Copy link
Member Author

Passing test for pymongo: https://spruce.mongodb.com/task/mongo_python_driver_testgcpoidc_variant_oidc_auth_test_gcp_latest_patch_79fb19c1a6e293278f5385b49b0c59740b5c571a_66270244f907a20007657216_24_04_23_00_35_29/logs?execution=0

katcharov
katcharov reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@katcharov katcharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blink1073 blink1073 merged commit 39f8532 into mongodb:master Apr 23, 2024
3 checks passed
@blink1073 blink1073 deleted the DRIVERS-2601-3 branch April 23, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katcharov katcharov katcharov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blink1073 @katcharov