Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIVERS-2511: Update maxWireVersion from 6 to 21 #1574

Merged
merged 2 commits into from
May 1, 2024

Conversation

jyemin
Copy link
Contributor

@jyemin jyemin commented May 1, 2024

Once a driver removes support for MongoDB 3.6 and updates its minWireVersion from 6 to 7, these tests start to fail due to the wire version compatibility check required by the test runner.

Bumping from 6 to 21 (MongoDB 7.0 maxWireVersion) should hold us for a while.

Note: I don't think the intention of any of these tests were to check the minWireVersion of the driver, as they have been at 6 long before 6 was the minWireVersion.

Please complete the following before merging:

  • [ N/A] Update changelog.
  • [ Done] Make sure there are generated JSON files from the YAML test files.
  • [ Done (Java)] Test changes in at least one language driver.
  • [ N/A] Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

Once a driver removes support for MongoDB 3.6 and updates its
minWireVersion from 6 to 7, these tests start to fail.

Bumping from 6 to 21 (MongoDB 7.0 maxWireVersion) should hold us
for a while.
@jyemin jyemin requested review from a team as code owners May 1, 2024 19:00
@jyemin jyemin requested review from jess-sig, dariakp and W-A-James and removed request for a team and dariakp May 1, 2024 19:00
source/resources Outdated Show resolved Hide resolved
@jyemin jyemin requested review from W-A-James and removed request for jess-sig May 1, 2024 19:48
@jyemin jyemin merged commit 959a5de into mongodb:master May 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants