DRIVERS-2836 OIDC: More Clarification and Test Cleanup #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
requested review from
comandeo-mongo,
katcharov,
sanych-sun and
durran
and removed request for
a team and
comandeo-mongo
katcharov
approved these changes
May 3, 2024
source/auth/tests/mongodb-oidc.md
Outdated
Comment on lines
82
to
83
| - Create an OIDC configured client with auth mechanism properties `{"ENVIRONMENT": "azure", "ALLOWED_HOSTS": []}`. | ||
| - Assert it returns a client configuration error. |
There was a problem hiding this comment.
Suggested change
| - Create an OIDC configured client with auth mechanism properties `{"ENVIRONMENT": "azure", "ALLOWED_HOSTS": []}`. | |
| - Assert it returns a client configuration error. | |
| - Create an OIDC configured client with auth mechanism properties `{"ENVIRONMENT": "azure", "ALLOWED_HOSTS": []}`. Perform a find, if necessary, to cause the ensuing error. | |
| - Assert it returns a client configuration error. |
In Java we validate on use (when the OidcAuthenticator is created). The check can be moved earlier, but it would not be as clean.
There was a problem hiding this comment.
Updated here and 2.4 as well.
sanych-sun
requested changes
May 6, 2024
| @@ -96,7 +101,7 @@ source the `secrets-export.sh` file and use the associated env variables in your | |||
|
|
|||
| **3.3 Unexpected error code does not clear the cache** | |||
|
|
|||
| - Create a `MongoClient` with a human callback that returns a valid token. | |||
| - Create a `MongoClient` with an OIDC callback that returns a valid token. | |||
There was a problem hiding this comment.
There are similar changes required on line 123 and 125.
katcharov
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please complete the following before merging:
clusters, and serverless).