Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rendering for bulk write JSON-like blocks #1583

Merged
merged 6 commits into from
May 10, 2024

Conversation

isabelatkinson
Copy link
Contributor

json code blocks don't render nicely in github when their contents aren't valid JSON, e.g.:

InsertOne {
   "namespace": "db.coll",
   "document": { "a": <int32> },
}

This PR ports them to javascript blocks, which look better:

InsertOne {
   "namespace": "db.coll",
   "document": { "a": <int32> },
}

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

@isabelatkinson isabelatkinson requested a review from a team as a code owner May 10, 2024 18:36
@isabelatkinson isabelatkinson requested review from nbbeeken and removed request for a team May 10, 2024 18:36
@isabelatkinson isabelatkinson requested review from kevinAlbs and removed request for nbbeeken May 10, 2024 18:36
@isabelatkinson isabelatkinson merged commit 6b753a3 into mongodb:master May 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants