Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRIVERS-2915 OIDC: Disallow comma character in authMechanismProperties connection string value #1588

Merged
merged 16 commits into from
Jun 5, 2024
Merged

DRIVERS-2915 OIDC: Disallow comma character in authMechanismProperties connection string value #1588

merged 16 commits into from
Jun 5, 2024

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented May 29, 2024 •
edited
Loading

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

@blink1073
Copy link
Member Author

mongodb/mongo-python-driver#1646

@blink1073 blink1073 marked this pull request as ready for review May 29, 2024 12:57
@blink1073 blink1073 requested a review from a team as a code owner May 29, 2024 12:57
@blink1073 blink1073 requested review from comandeo-mongo, addaleax, a team and katcharov and removed request for a team May 29, 2024 12:57
durran
durran approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good on Node: https://spruce.mongodb.com/version/665733802e5c87000793c3b6/tasks?page=0&sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC&variant=%5Eubuntu20-test-all-oidc%24

@blink1073 blink1073 requested a review from addaleax May 29, 2024 14:17
addaleax
addaleax approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

jyemin
jyemin requested changes May 29, 2024
View reviewed changes
source/auth/auth.md Outdated Show resolved Hide resolved
source/auth/auth.md Outdated Show resolved Hide resolved
durran
durran requested changes May 29, 2024
View reviewed changes
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one JSON change.

blink1073 and others added 3 commits May 29, 2024 10:04
@blink1073 @jyemin
Update source/auth/auth.md
e995a42 
Co-authored-by: Jeff Yemin <jeff.yemin@mongodb.com>
@blink1073 @durran
Update source/auth/tests/legacy/connection-string.json
46836a5 
Co-authored-by: Durran Jordan <durran@gmail.com>
@blink1073
update connection string logic
3a719c7
@blink1073 blink1073 requested a review from durran May 29, 2024 15:11
@blink1073 blink1073 requested a review from a team as a code owner May 29, 2024 15:11
@blink1073 blink1073 requested review from dariakp, jyemin and addaleax and removed request for a team May 29, 2024 15:11
jyemin
jyemin requested changes May 29, 2024
View reviewed changes
source/connection-string/connection-string-spec.md Outdated Show resolved Hide resolved
source/connection-string/connection-string-spec.md Outdated Show resolved Hide resolved
source/connection-string/connection-string-spec.md Outdated Show resolved Hide resolved
katcharov
katcharov requested changes May 29, 2024
View reviewed changes
source/connection-string/connection-string-spec.md Outdated Show resolved Hide resolved
source/auth/auth.md Show resolved Hide resolved
katcharov
katcharov requested changes May 29, 2024
View reviewed changes
source/connection-string/connection-string-spec.md Outdated Show resolved Hide resolved
source/connection-string/connection-string-spec.md Outdated Show resolved Hide resolved
source/connection-string/connection-string-spec.md Outdated Show resolved Hide resolved
blink1073 and others added 2 commits May 29, 2024 16:54
@blink1073 @katcharov
Update source/connection-string/tests/valid-options.yml
5920e43 
Co-authored-by: Maxim Katcharov <maxim.katcharov@mongodb.com>
@blink1073
update json test
e4af039
@blink1073 blink1073 requested a review from katcharov May 29, 2024 21:55
@jyemin jyemin removed the request for review from dariakp May 30, 2024 21:44
blink1073 and others added 4 commits June 3, 2024 19:41
@blink1073 @katcharov
Update source/connection-string/connection-string-spec.md
ac2e22c 
Co-authored-by: Maxim Katcharov <maxim.katcharov@mongodb.com>
@blink1073 @katcharov
Update source/connection-string/connection-string-spec.md
49fcb35 
Co-authored-by: Maxim Katcharov <maxim.katcharov@mongodb.com>
@blink1073 @katcharov
Update source/connection-string/connection-string-spec.md
872b8c0 
Co-authored-by: Maxim Katcharov <maxim.katcharov@mongodb.com>
@blink1073
formatting
303811e
@blink1073 blink1073 requested a review from katcharov June 4, 2024 00:46
katcharov
katcharov approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@katcharov katcharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

JamesKovacs
JamesKovacs approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@JamesKovacs JamesKovacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blink1073 blink1073 merged commit 2603c51 into mongodb:master Jun 5, 2024
3 checks passed
@blink1073 blink1073 deleted the DRIVERS-2915 branch June 5, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyemin jyemin jyemin approved these changes

@addaleax addaleax addaleax approved these changes

@JamesKovacs JamesKovacs JamesKovacs approved these changes

@katcharov katcharov katcharov approved these changes

@durran durran durran approved these changes

@comandeo-mongo comandeo-mongo Awaiting requested review from comandeo-mongo comandeo-mongo is a code owner automatically assigned from mongodb/dbx-spec-owners-auth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@blink1073 @durran @katcharov @JamesKovacs @addaleax @jyemin