Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIVERS-2732 Remove extra listCollections from KMIP delegated tests #1591

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

adriandole
Copy link
Contributor

@adriandole adriandole commented Jun 3, 2024

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

An extra listCollections event was included by mistake in the JSON test from KMIP delegated. The test passes with the C driver despite the inclusion because of a quirk in the C driver's test runner. Thanks @katcharov for spotting it.

@adriandole adriandole requested a review from a team as a code owner June 3, 2024 20:37
@adriandole adriandole requested review from katcharov and removed request for a team June 3, 2024 20:37
Copy link
Contributor

@katcharov katcharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adriandole adriandole merged commit dc6eb4c into mongodb:master Jun 3, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants