Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix uri in username with test environment oidc test #1597

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

durran
Copy link
Member

@durran durran commented Jun 5, 2024

Please complete the following before merging:

When implementing OIDC in the Ruby driver I noticed that the username with ENVIRONMENT:test spec test was not failing because of the username being present but rather the URI was actually invalid, since ENVIRONMENT:test was not in the authMechanismProperties. This fixes that test.

Tests running on this PR: mongodb/mongo-ruby-driver#2873

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

@durran durran marked this pull request as ready for review June 5, 2024 22:22
@durran durran requested a review from a team as a code owner June 5, 2024 22:22
@durran durran requested review from comandeo-mongo and blink1073 and removed request for a team June 5, 2024 22:22
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@durran durran merged commit 57cdf9b into master Jun 7, 2024
3 checks passed
@durran durran deleted the oidc-auth-spec-fix branch June 7, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants