Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIVERS-2776 test compact with "range" #1605

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

kevinAlbs
Copy link
Contributor

@kevinAlbs kevinAlbs commented Jun 27, 2024

Summary

  • Assert successful response to compactStructuredEncryptionData.
  • Add fle2v2-Rangev2-Compact to test compact with "range".

Partially resolves DRIVERS-2776.

Background & Motivation

Spec tests are motivated by the bug fix in MONGOCRYPT-699.

Adding result: { ok: 1 } to the operation is to ensure test runners check the operation succeeded. The test format does not require checking the operation succeeded if result is not present.

An "insert" operation is added before compactStructuredEncryptionData for the range test. The server check requiring encryptionInformation appears to require data present to trigger the error.

Please complete the following before merging:

  • [ ] Update changelog. N/A. Test changes only.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver. Tested in C.
  • [ ] Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).
    C driver does not currently test IUE with sharded or serverless.

@kevinAlbs kevinAlbs marked this pull request as ready for review June 28, 2024 12:16
@kevinAlbs kevinAlbs requested a review from a team as a code owner June 28, 2024 12:16
@kevinAlbs kevinAlbs requested review from adriandole and removed request for a team June 28, 2024 12:16
@kevinAlbs kevinAlbs merged commit 06bceb0 into mongodb:master Aug 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants