Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changelog rendering in server-discovery-and-monitoring-logging-and-monitoring.md #1608

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Jul 3, 2024

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

Fix some git diff left in the markdown

@nbbeeken nbbeeken requested a review from a team as a code owner July 3, 2024 14:32
@nbbeeken nbbeeken requested review from W-A-James and removed request for a team July 3, 2024 14:32
Copy link
Contributor

@W-A-James W-A-James left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint failure.

Run

pre-commit run --show-diff-on-failure --color=always --all-files

and commit the changes

@ShaneHarvey
Copy link
Member

This is already fixed in #1594 which looks like it stalled. Let's see if #1594 can be merged instead.

@nbbeeken nbbeeken closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants