DRIVERS-1725 Unskip failCommand+appName tests on MongoDB 4.4.7+ #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
requested review from
W-A-James and
dariakp
and removed request for
a team
W-A-James
approved these changes
Jul 19, 2024
|
@dariakp do you plan to review this or do you want to defer to Warren's review? |
dariakp
requested changes
Aug 5, 2024
source/server-discovery-and-monitoring/tests/unified/interruptInUse-pool-clear.yml
Show resolved
Hide resolved
@ShaneHarvey sorry I didn't see the review request, it must have come in while I was still out on leave. If @W-A-James ran all these tests in the Node CI, I can defer to his review, other than the one question. |
|
@qingyang-hu your review is required as the CSOT co-owner. |
qingyang-hu
approved these changes
Aug 6, 2024
dariakp
approved these changes
Aug 6, 2024
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRIVERS-1725
Please complete the following before merging:
clusters, and serverless).