-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRIVERS-2951 Test serverMonitoringMode=poll waits after a successful heartbeat #1626
Conversation
@prestonvasquez could you review this to ensure it covers the Go driver bug? When I introduce the bug in Python the test fails like this:
|
@ShaneHarvey Go has not implemented DRIVERS-2366 and so we don't have
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the file runs this on standalones, replicasets and sharded clusters. It seems that we'd either want to write separate tests for replsets and sharded clusters or we want to restrict this to run against standalones.
source/server-discovery-and-monitoring/tests/unified/serverMonitoringMode.yml
Outdated
Show resolved
Hide resolved
We already have this at the top of the file:
This test works on both standalone and sharded clusters. |
Fixes DRIVERS-2951.
Please complete the following before merging:
clusters, and serverless).
Question, should we still update the prose test here added in DRIVERS-1251 to run on both streaming and polling? Currently it implicitly tests polling on <4.4 servers.