-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRIVERS-2922: Allow valid SRV hostnames with fewer than 3 parts #1628
Conversation
d110745
to
a663ea3
Compare
lint clarify fix capitalization
67e06f9
to
f27364c
Compare
608f76e
to
f27364c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start, there's a markdown format linter error and see comments:
source/initial-dns-seedlist-discovery/initial-dns-seedlist-discovery.md
Outdated
Show resolved
Hide resolved
source/initial-dns-seedlist-discovery/initial-dns-seedlist-discovery.md
Outdated
Show resolved
Hide resolved
source/initial-dns-seedlist-discovery/initial-dns-seedlist-discovery.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A driver MUST verify that the host names returned through SRV records have the same parent
{domainname}
. Drivers MUST
raise an error and MUST NOT initiate a connection to any returned host name which does not share the same
{domainname}
.
This section needs adjusting to include what validation is done when there is only one level in the domain.
source/initial-dns-seedlist-discovery/initial-dns-seedlist-discovery.md
Outdated
Show resolved
Hide resolved
source/initial-dns-seedlist-discovery/initial-dns-seedlist-discovery.md
Outdated
Show resolved
Hide resolved
source/initial-dns-seedlist-discovery/initial-dns-seedlist-discovery.md
Outdated
Show resolved
Hide resolved
source/initial-dns-seedlist-discovery/initial-dns-seedlist-discovery.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-commit is failing: https://github.com/mongodb/specifications/actions/runs/10885366203/job/30202807636
source/initial-dns-seedlist-discovery/initial-dns-seedlist-discovery.md
Outdated
Show resolved
Hide resolved
…odb#1628) * feat(DRIVERS-2922): loosen options parser restrictions lint clarify fix capitalization * add test criteria * grammar fix * wording fix * temp commit - changing terminology * change terminology * update changelog * add in prose test ref * add parent matching requirements * update changelod * added in new prose test requirements + fixed formatting * requested changes * requested changes 2 * uniform formatting + fix typo * team review requested changes * team review requested changes * team review requested changes 2 * update deprecation comment * typo * clarify subdomain * add in Shanes test * update changelog date * add in specific cases * fix test cases * fix tests * fix tests * grammar fix
Description
SRVs are no longer required to have a given number of parts, URI terminology is more clearly defined, and stricter parent match requirements are introduced.
What is changing?
.
separated parts in the hostname is no longer required.'hostname'
refers to the entire{hostname}
and that the{subdomain}
is only part of the hostname. Previously, in the document,{hostname}
referred to the{subdomain}
and'hostname'
referred to the{subdomain}.{domainname}
which was confusingProof of Concept
See here for Node's PoC/implementation of downstream changes.
Please complete the following before merging:
clusters, and serverless).