Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRIVERS-2250: Define Wire versions for host b in too_new and too_old tests #1632

Merged
merged 3 commits into from
Aug 16, 2024
Merged

DRIVERS-2250: Define Wire versions for host b in too_new and too_old tests #1632

merged 3 commits into from
Aug 16, 2024

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Aug 16, 2024 •
edited by ShaneHarvey
Loading

DRIVERS-2250

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

@W-A-James W-A-James marked this pull request as ready for review August 16, 2024 17:23
@W-A-James W-A-James requested a review from a team as a code owner August 16, 2024 17:23
@W-A-James W-A-James requested review from nbbeeken and removed request for a team August 16, 2024 17:23
ShaneHarvey
ShaneHarvey approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass in python

@W-A-James W-A-James merged commit a084545 into mongodb:master Aug 16, 2024
4 checks passed
@W-A-James W-A-James deleted the DRIVERS-2250 branch August 16, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaneHarvey ShaneHarvey ShaneHarvey approved these changes

@nbbeeken nbbeeken Awaiting requested review from nbbeeken nbbeeken is a code owner automatically assigned from mongodb/dbx-spec-owners-sdam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@W-A-James @ShaneHarvey