Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIVERS-2789 Add script to check for malformed links #1637

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

blink1073
Copy link
Member

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

@blink1073 blink1073 requested a review from a team as a code owner August 21, 2024 14:53
@blink1073 blink1073 requested review from dariakp and Jibola and removed request for a team and Jibola August 21, 2024 14:53
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just as a sanity check - could you add a commit to this PR with a broken link to demo it getting caught by this script?

@blink1073
Copy link
Member Author

just as a sanity check - could you add a commit to this PR with a broken link to demo it getting caught by this script?

I did that locally

@blink1073 blink1073 requested a review from dariakp August 21, 2024 15:46
@dariakp
Copy link
Contributor

dariakp commented Aug 21, 2024

just as a sanity check - could you add a commit to this PR with a broken link to demo it getting caught by this script?

I did that locally

Of course, my thought was just that since these checks will run in GH on the PR itself, we have an opportunity to run the "test" in CI as well, capturing the red x next to the test commit for posterity, instead of just relying on local execution.

Anyway, that's fine. Is there any concern about this script accidentally catching distributed brackets in code snippets?

@blink1073
Copy link
Member Author

Of course, my thought was just that since these checks will run in GH on the PR itself, we have an opportunity to run the "test" in CI as well, capturing the red x next to the test commit for posterity, instead of just relying on local execution.

I've been using "rebase and merge" to make sure I don't miss the RST->MD renaming commit, and I don't want to accidentally forget to change it back after using a "squash and merge" on a PR.

Is there any concern about this script accidentally catching distributed brackets in code snippets?

Good call, I'll add detection of whether we're in a code block.

@blink1073
Copy link
Member Author

I verified this behavior locally as well.

@blink1073 blink1073 merged commit e68ed91 into mongodb:master Aug 21, 2024
4 checks passed
@blink1073 blink1073 deleted the DRIVERS-2789-malformed-links branch August 21, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants