Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRIVERS-2789 Convert Run Command Spec to Markdown #1646

Merged
merged 3 commits into from
Sep 3, 2024
Merged

DRIVERS-2789 Convert Run Command Spec to Markdown #1646

merged 3 commits into from
Sep 3, 2024

Conversation

blink1073
Copy link
Member

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

@blink1073 blink1073 requested review from a team as code owners September 3, 2024 11:33
@blink1073 blink1073 requested review from jmikola, dariakp and qingyang-hu and removed request for a team, jmikola and dariakp September 3, 2024 11:33
nbbeeken
nbbeeken approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 Yay runCommand!

@blink1073 blink1073 merged commit 802c074 into mongodb:master Sep 3, 2024
3 checks passed
@blink1073 blink1073 deleted the DRIVERS-2789-run-command branch September 3, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@qingyang-hu qingyang-hu Awaiting requested review from qingyang-hu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blink1073 @nbbeeken