Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify requirements for range explicit encryption prose test #1657

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Sep 13, 2024

Consolidates the first note and preceding paragraph to state that the test requires MongoDB 8.0+ and libmongocrypt 1.11+.

Removes the second note about MongoDB 7.0, which is no longer relevant.

Notes that the test should not be run on a standalone server, similar to prose test 21.

Additional context for this change can be found in this Slack thread.

Consolidates the first note and preceding paragraph to state that the test requires MongoDB 8.0+ and libmongocrypt 1.11+.

Removes the second note about MongoDB 7.0, which is no longer relevant.

Notes that the test should not be run on a standalone server, similar to prose test 21.
@jmikola jmikola requested a review from a team as a code owner September 13, 2024 17:42
@jmikola jmikola requested review from kevinAlbs and removed request for a team September 13, 2024 17:42
> libmongocrypt 1.8.0 is configured to use the QEv2 protocol.
The Range Explicit Encryption tests utilize Queryable Encryption (QE) range protocol V2 and require MongoDB server
8.0.0-rc14+ for [SERVER-91889](https://jira.mongodb.org/browse/SERVER-91889) and libmongocrypt 1.11.0+ for
[MONGOCRYPT-705](https://jira.mongodb.org/browse/MONGOCRYPT-705). The tests must not run against a standalone.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the standalone requirement was communicated in some previous iteration of this prose test, but it was done by both libmongoc and PHPLIB.

Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM

@jmikola jmikola merged commit 1e9b181 into master Sep 13, 2024
4 checks passed
@jmikola jmikola deleted the csfle-prose-22 branch September 13, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants